Replies: 1 comment
-
Because you might not have access to secrets to log in to the registry using |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I feel like I generally understand the concept of this workflow, but I'm just not following logic behind the Basic Example.
The example starts with this:
I interpret this as triggering this workflow any time a pull request is opened against the master branch. It seems like this would be useful for evaluating a pull request because the image would be ready to test without having to manually checkout and build it.
However, I then see this part:
In particular, the
push: ${{ github.event_name != 'pull_request' }}
is confusing without any specific comments on why that might be used. In other words, why would you not want to push an image for a pr if you have already gone through the trouble of building the image? I suppose that we might want to just see that the image is built, but why would we not want to just go ahead and have the image anyways?It just seems like this very specific approach is being used in multiple examples(1, 2, 3) without some explanation of what the underlying goal is. This just adds to the uncertainty of reading and understanding the documentation.
Beta Was this translation helpful? Give feedback.
All reactions