Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor publisher-video-view and viewer-video-view #291

Open
2 tasks
vincentsong opened this issue Feb 6, 2023 · 0 comments
Open
2 tasks

Refactor publisher-video-view and viewer-video-view #291

vincentsong opened this issue Feb 6, 2023 · 0 comments
Assignees
@jackshen

Comments

@vincentsong
Copy link
Collaborator

vincentsong commented Feb 6, 2023 •
edited
Loading

  • There are duplicated UI and function codes in both, we should consolidate them and use property to differentiate them. So it would be easier to maintain in future.
  • Provide an interface in the action bar for the application to fill any UI elements, such as the start/stop live button
@vincentsong vincentsong mentioned this issue Feb 6, 2023
Merged
@vincentsong vincentsong changed the title Consolidate publisher-video-view and viewer-video-view Refactor publisher-video-view and viewer-video-view Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackshen jackshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentsong @jackshen