Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the CPDF library into its own GIT subproject #184

Open
PhenX opened this issue Dec 6, 2012 · 3 comments
Open

Move the CPDF library into its own GIT subproject #184

PhenX opened this issue Dec 6, 2012 · 3 comments

Comments

@PhenX
Copy link
Member

PhenX commented Dec 6, 2012

Original author: eclecticgeek (September 03, 2010 00:48:03)

Since DOMPDF is supposed to be library independent I think it would make sense to have the development of the CPDF renderer be semi-independent of the DOMPDF library. Naturally the two have to be developed somewhat hand in hand, especially since CPDF is the default library of DOMPDF. However, I don't see any reason we can't develop the library in it's own SVN path and use SVN externals to pull it back in. Following standard SVN development practices we can develop in the CPDF trunk and link to tagged versions.

I like this idea, but it certainly deserves scrutiny from everyone else. Worthwhile or not?

Original issue: http://code.google.com/p/dompdf/issues/detail?id=178

@simonberger simonberger changed the title Move the CPDF library into its own SVN subproject Move the CPDF library into its own GIT subproject Mar 1, 2020
@simonberger
Copy link
Member

Can this step be done now? I noted that there is a repository in Phenx namespace which received just the initial commit three years ago. But the CPDF used in Dompdf got a lot of (special ?) changes since this time.
A repository under dompdf would make more sense too.

Is there anything preventing this to happen? We could make this even a compatible change. But the last namespace change (actually adding one) was part of a minor update too.

@bsweeney
Copy link
Member

bsweeney commented Mar 1, 2020

I think we can move forward with this change. Would make sense to maintain this separately especially since we now have two projects using CPDF.

@simonberger
Copy link
Member

If an repository (and packagist entry) exists I would do the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants