check if ini_set is available to prevent Fatal Errors #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltfield
commented
Sep 13, 2024
maltfield
commented
- PHP Fatal error: Call to undefined function ini_set #3523
bsweeney
reviewed
Sep 13, 2024
Comment on lines
+287
to
+298
| if (function_exists('ini_get') && function_exists('ini_set')) { | ||
| if (sprintf('%.1f', 1.0) !== '1.0') { | ||
| $this->systemLocale = setlocale(LC_NUMERIC, "0"); | ||
| setlocale(LC_NUMERIC, "C"); | ||
| } | ||
|
|
||
| $this->pcreJit = @ini_get('pcre.jit'); | ||
| @ini_set('pcre.jit', '0'); | ||
| $this->pcreJit = @ini_get('pcre.jit'); | ||
| @ini_set('pcre.jit', '0'); | ||
|
|
||
| $this->mbstringEncoding = mb_internal_encoding(); | ||
| mb_internal_encoding('UTF-8'); | ||
| $this->mbstringEncoding = mb_internal_encoding(); | ||
| mb_internal_encoding('UTF-8'); | ||
| } |
There was a problem hiding this comment.
Why did you wrap this whole block in the condition instead of just the lines using ini_get/ini_set?
There was a problem hiding this comment.
because I assumed that was the best way to do this with the fewest number of lines changed. I can add a few more conditionals so that only the 1-line ini_set and ini_get calls are wrapped, if others think that's better?
There was a problem hiding this comment.
The preference would be to change only the relevant lines. You're also disabling changes to locale and internal encoding, both of which can completely break rendering if configured in a way that's incompatible with Dompdf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.