Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates for the 3.1.0 release #3571

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Minor updates for the 3.1.0 release #3571

wants to merge 6 commits into from

Conversation

bsweeney
Copy link
Member

@bsweeney bsweeney commented Jan 4, 2025

  • Fixes body element retrieval for fixed-position elements
  • Fixes potentially invalid font reference in Cpdf
  • Updates conditional pseudo-element (::before/::after) generation and rendering
  • Halts CSS calculations when operands are missing
  • Adds support for CSS selectors with escaped characters

@bsweeney bsweeney linked an issue Jan 4, 2025 that may be closed by this pull request
The previous logic attempted to simplify the process by retrieving the first element of the document root. After the first page this would be incorrect since the previous body element exists in the frame tree until the after the current body completed rendering.

fixes #3570
@bsweeney bsweeney added this to the 3.1.0 milestone Jan 6, 2025
This change prevents logic or rendering errors in scenarios where a CSS calc function utilizes a non-existent variable as one of the operands.

ref #3530
@bsweeney bsweeney linked an issue Jan 11, 2025 that may be closed by this pull request
@bsweeney bsweeney changed the title Minor bug fixes for the 3.1.0 release Minor updates for the 3.1.0 release Jan 11, 2025
Prior to this change a pseudo-element would not be generated if it's only content was a custom property reference. This is because the frame is generated before styles are applied and the custom property reference is unable to resolve. The lack of content in a pseudo-element precludes frame generation.

Even if a frame is generated, it is not rendered to the page if it has no content. This change modifies the content check to exclude only if there is no content (null) rather than empty ("").

fixes #2775 and #3573
Though not valid per the spec to include whitespace in the non-data portion of the data-URI, browser do perform a similar operation. The whitespace removal is done after initial failure in order to minimize impact on documents with a correcty formatted data-URIs.

fixes #1386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment