Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Open File for varying network modes (GRN/PPI) #1066

Closed
dondi opened this issue Nov 14, 2023 · 2 comments
Closed

Adjust Open File for varying network modes (GRN/PPI) #1066

dondi opened this issue Nov 14, 2023 · 2 comments

Comments

@dondi
Copy link
Owner

dondi commented Nov 14, 2023

The Open File functionality needs to support PPIs more “natively” than they do now. Specifically:

  • only .xlsx and .sif should be allowed for PPI, not .graphml
  • check .sif format for PPI

In addition, instead of having the Network Mode lock in which files can be opened, would it be possible for the open-file command itself to determine the Network Mode based on the selected file? e.g., if the user picks a GraphML file, then we switch to GRN network mode for sure. Also if opening a demo, we can switch the Network Mode automatically at that time

For .sif files, an edge label of pp indicates a PPI. Thus, “pre-reading” a .sif can also set Network Mode upon opening

@dondi dondi added the network label Nov 14, 2023
@dondi dondi changed the title Adjust Network > Open File for PPINs Adjust Network > Open File for PPIs Nov 14, 2023
@dondi dondi changed the title Adjust Network > Open File for PPIs Adjust Open File for PPIs Nov 14, 2023
@dondi dondi changed the title Adjust Open File for PPIs Adjust Open File for varying network modes (GRN/PPI) Nov 14, 2023
@dondi dondi mentioned this issue Nov 28, 2023
@ntran18 ntran18 mentioned this issue Jan 23, 2024
26 tasks
@ntran18
Copy link
Collaborator

ntran18 commented Nov 27, 2024

Network.Mode.Detection.mp4

I believe PR #1085 already fix this issue. This video didn't test the excel files.

@dondi
Copy link
Owner Author

dondi commented Dec 4, 2024

Verified on v7.1.11 beta during 12/4 meeting

@dondi dondi closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants