Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclaimer for lack of node-coloring PPI support #1071

Closed
dondi opened this issue Nov 21, 2023 · 3 comments
Closed

Disclaimer for lack of node-coloring PPI support #1071

dondi opened this issue Nov 21, 2023 · 3 comments

Comments

@dondi
Copy link
Owner

dondi commented Nov 21, 2023

As a stopgap before working on #1068, we should include a disclaimer that we are displaying gene expression (mRNA-level data) and not protein-level data somewhere in the UI

@dondi
Copy link
Owner Author

dondi commented Nov 21, 2023

Immediate task would be to prohibit changing the network mode for an existing graph because as of now, the change of mode makes the graph incorrect

Instead of disabling the dropdown, informational text in the style of the Species indicator should be used

  • In the current framework this will require including both options in the markup but selectively hiding/unhiding the right one
  • Future frameworks may be able to modify the app content dynamically, rendering or omitting the corresponding element as needed

If we end up waiting on this change, it may be necessary to display a warning message about the incorrect behavior that would take place when the Network Mode is changed for an existing graph

@kdahlquist
Copy link
Collaborator

This issue is superseded by #1080 where we have decided to enable node coloring with PPI networks. However, adding a warning may still be appropriate. For example, when a PPI network is loaded, default to disable the node coloring, but allow the user to enable it. When they enable it, a warning modal can appear that says "You are displaying mRNA-level expression data on a protein-protein interaction network."

In the future, we can consider allowing the user to upload protein-level expression data as an Excel workbook, but that is beyond the scope of this semester.

@dondi
Copy link
Owner Author

dondi commented Oct 16, 2024

Closing since #1080 addresses this issue more fully

@dondi dondi closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants