Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing empty network with network tab of Excel file crashes the website #1091

Closed
ntran18 opened this issue Feb 1, 2024 · 2 comments
Closed

Importing empty network with network tab of Excel file crashes the website #1091

ntran18 opened this issue Feb 1, 2024 · 2 comments
Assignees
@ceciliazaragoza @ntran18
Labels
bug for next release priority 0

Comments

@ntran18
Copy link
Collaborator

ntran18 commented Feb 1, 2024

@ceciliazaragoza mentioned in PR #1085 . When importing an Excel file with a network tab with empty data, the website will stop working.
@ntran18 ntran18 self-assigned this Feb 1, 2024
ceciliazaragoza added a commit that referenced this issue Feb 3, 2024
@ceciliazaragoza
Working on issue #1091. Fixed issue caught in PR #1085 with file test…
5903498 
…-files/semantic-error-test-files/empty-network-xlsx-with-network-tab.xlsx. Added a try-catch that makes error modal pop up
@ceciliazaragoza
Copy link
Collaborator

I worked on this, and I added a try-catch that catches the error if data[0][0] for cell A1 is undefined.

ceciliazaragoza added a commit that referenced this issue Feb 3, 2024
@ceciliazaragoza
Working on issue #1091 that found issue in PR #1085. Adjusted code fo…
5db1472 
…r lint errors
@ceciliazaragoza
Copy link
Collaborator

Adjusted code for lint errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliazaragoza ceciliazaragoza

@ntran18 ntran18

Labels
bug for next release priority 0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ceciliazaragoza @ntran18