Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D-pad, zoom slider, and cursor drag do not move graph after export to SVG #1093

Open
ceciliazaragoza opened this issue Feb 13, 2024 · 3 comments

Comments

@ceciliazaragoza
Copy link
Collaborator

ceciliazaragoza commented Feb 13, 2024

After exporting a graph to SVG, the D-pad can be clicked and the zoom slider can be moved. However, the cursor hand does not close, and the graph does not move and remains at the same zoom and position as when exported. However, if you reload the graph, choose a demo, or open a file, the cursor grab and zoom slider move the graph again. This issue is in the master branch as well.

@ceciliazaragoza ceciliazaragoza changed the title Cursor grab and zoom slider do not move graph after export to SVG D-pad, zoom slider, and cursor drag do not move graph after export to SVG Feb 13, 2024
@ceciliazaragoza ceciliazaragoza self-assigned this Feb 13, 2024
@dondi
Copy link
Owner

dondi commented Feb 13, 2024

Suspicion here is that the export routine manipulates the SVG elements in-place to make them export ready but those changes then impact the web app. Ideally the SVG export operates on a deep copy of the SVG tree so that it doesn’t leave any unintended side effects

@ceciliazaragoza
Copy link
Collaborator Author

ceciliazaragoza commented Apr 2, 2024

This seems to be the same issue as in #1059 because the SVG is modifying the graph itself.

@dondi
Copy link
Owner

dondi commented Apr 2, 2024

To elaborate further, #1059 may be the root cause of this bug; that is currently assigned to @ntran18. @ceciliazaragoza will monitor both issues and update accordingly if it does turn out that they are bound together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants