Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloseNotify() is deprecated #43

Open
perpetual-hydrofoil opened this issue Jul 23, 2019 · 1 comment
Open

CloseNotify() is deprecated #43

perpetual-hydrofoil opened this issue Jul 23, 2019 · 1 comment

Comments

@perpetual-hydrofoil
Copy link

Unfortunately, CloseNotify() is deprecated:

"Deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead." (https://golang.org/pkg/net/http/#CloseNotifier)
@perpetual-hydrofoil
Copy link
Author

(Why this matters: it makes eventsource incompatible with most newer plugins/middleware that use context or that wrap the ResponseWriter like loggers, routers like fasthttp routers, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@perpetual-hydrofoil