-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify list when a review summary comment/decision gets entered #21
Comments
unfortunately, it doesn't look like github emits any event for those at the moment |
looks like it is possible (not sure if it is "after all" or "now"): https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent |
Ok, great -- it'd be really good to please add forwarding reviews and review comments to the mailing list because folks are using reviews, sometimes inadvertently. |
In fact, i'd be inclined to have github-notify-ml forward reviews, review comments, and regular comments if the mailing list is config'd to receive "comments". |
i.e., I'd be tempted to have..
..all apply to both "issues" and "reviews" (i.e., all of "opened", "_comment.created", "closed") |
GitHub introduced a pull request review mechanism that groups inline review comments together and allows a reviewer to approve or request changes to the PR with a review summary comment.
Issue #20 discusses inline comments. The comment I'm most interested here is the review summary along with the decision to approve/reject the review. The tool currently seems to miss it, so I suppose this review summary comment does not get reported in an
issue_comment.created
event.I'm not sure what event gets triggered in that case, perhaps
pull_request_review_comment
?For an example of a pull request with a review summary comment, see: w3c/presentation-api#351
The text was updated successfully, but these errors were encountered: