You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
since new Buffer(string) is deprecated since Node v6 and emits a deprecation warning when run outside node_modules (such as when append-buffer is bundled in Node.js CLI apps), I'd like to ask for your opinion about replacing it with Buffer.from(string) when available. Fully replacing it would call for a v2 of this lib, likely taking a long time to be adopted (esp. given the large number of transitive dependents), so I'd check for Buffer.from to be defined instead. Happy to submit a PR if you agree.
Cheers!
The text was updated successfully, but these errors were encountered:
Hi @doowb,
since
new Buffer(string)
is deprecated since Node v6 and emits a deprecation warning when run outsidenode_modules
(such as whenappend-buffer
is bundled in Node.js CLI apps), I'd like to ask for your opinion about replacing it withBuffer.from(string)
when available. Fully replacing it would call for a v2 of this lib, likely taking a long time to be adopted (esp. given the large number of transitive dependents), so I'd check forBuffer.from
to be defined instead. Happy to submit a PR if you agree.Cheers!
The text was updated successfully, but these errors were encountered: