Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of new Buffer(string) #1

Open
bjoluc opened this issue Mar 5, 2022 · 0 comments
Open

Deprecation of new Buffer(string) #1

bjoluc opened this issue Mar 5, 2022 · 0 comments

Comments

@bjoluc
Copy link

bjoluc commented Mar 5, 2022

Hi @doowb,

since new Buffer(string) is deprecated since Node v6 and emits a deprecation warning when run outside node_modules (such as when append-buffer is bundled in Node.js CLI apps), I'd like to ask for your opinion about replacing it with Buffer.from(string) when available. Fully replacing it would call for a v2 of this lib, likely taking a long time to be adopted (esp. given the large number of transitive dependents), so I'd check for Buffer.from to be defined instead. Happy to submit a PR if you agree.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant