Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different loggers for different log sources #12

Open
xmkg opened this issue Sep 4, 2023 · 1 comment
Open

Use different loggers for different log sources #12

xmkg opened this issue Sep 4, 2023 · 1 comment

Comments

@xmkg
Copy link
Contributor

xmkg commented Sep 4, 2023

Currently, searchkit uses the default logger for logging, and there is no distinction between log sources. Searchkit ideally should have its own dedicated loggers, preferably in a reasonable granularity to have better control on logging, e.g. ("searchkit.searchdef", "searchkit.constraints.datesince")

@dosaboy
Copy link
Owner

dosaboy commented Sep 4, 2023

@mustafakemalgilor I fixed the issue of using the root logger just recently [1]. I like your suggestion of adding more fine grain loggers.

[1] https://github.com/dosaboy/searchkit/blob/main/searchkit/log.py#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants