Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Integrating Azure AD into an ASP.NET Core web app" to ASP.NET 2.0 #4449

Closed
Rick-Anderson opened this issue Sep 29, 2017 · 9 comments
Closed
Assignees
Labels
Pri0 Urgent priority

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Sep 29, 2017

Currently in review here

@jmprieur can you give me an ETA on when you can get these updated? Once you get it updated I can do an edit pass on the doc. We point to this doc at https://docs.microsoft.com/en-us/aspnet/core/security/authentication/azure-active-directory/

@Rick-Anderson Rick-Anderson added the Pri0 Urgent priority label Sep 29, 2017
@Rick-Anderson Rick-Anderson added this to the Sprint 125(09/30/17 - 10/2017) milestone Sep 29, 2017
@Rick-Anderson Rick-Anderson self-assigned this Sep 29, 2017
@jmprieur
Copy link
Contributor

jmprieur commented Oct 2, 2017

@Rick-Anderson : I've updated the sample in GitHub for the first one (See https://github.com/Azure-Samples/active-directory-dotnet-webapp-openidconnect-aspnetcore)
Working on the others.

@guardrex
Copy link
Collaborator

guardrex commented Oct 2, 2017

I have a concern that since it doesn't match the samples over here for the (hypothetical) 2.0 xplat best practices setup that devs (newbies anyway) will find it confusing:

  • Configured as a VS solution
  • Unnecessary defaults are specified in the project file (and PackageTargetFallback shouldn't be necessary ... in theory! lol)
  • wwwroot handling in an ItemGroup
  • Not using the All package
  • Not using the CreateDefaultBuilder startup pattern (with Startup adjustments for 2.0) + IConfigurationRoot
  • Gulp? (no BundlerMinifier.Core)
  • config.json? (with appsettings.json in use)
  • web.config-based ... and do transforms work yet? As of late last year, it wasn't possible. The GH tracking for tooling is gone now, so I can't see the progress on that: Add support for xdt (web.config) transforms aspnet/Tooling#252
  • Environment TH isn't using the new includes/excludes attributes
  • ... and a few other little things that don't match the latest templates

It might be a good idea to see how it would compose based a current dotnet new mvc auth template, but even the possibility of that option is based on where/how the sample is mentioned in Azure topics.

Anywho ... I have some time today, so let me know if u would like me to make a pass on it.

@jmprieur
Copy link
Contributor

jmprieur commented Oct 2, 2017

@guardrex : please go ahead.

@guardrex
Copy link
Collaborator

guardrex commented Oct 2, 2017

@jmprieur Sure thing ... I'll have it for ya this evening.

I'll go with a dotnet new mvc auth template first and see if it all composes well. I'll do a search for this sample to see if any topics need a touch of work to go along with the updates.

@Rick-Anderson
Copy link
Contributor Author

@guardrex Should I assign this to someone?

@Rick-Anderson Rick-Anderson modified the milestones: Sprint 126 (10/21/17 - 11/10/17), Sprint 127 (11/11/17 - 12/01/17) Nov 21, 2017
@guardrex
Copy link
Collaborator

@Rick-Anderson Looking at your list ☝️ one at a time ...

Integrating Azure AD into an ASP.NET Core web app

I made the final three touch-ups to that sample at Update Azure AD/OIDC sample (29):

  1. It had a tiny conflict in its README.md.
  2. I updated the version of UseMvc that has the routes.MapRoute in it to match the template.
  3. I added back the Bower and BundlerMinifer.Core files (although they don't work outside of VS as usual).

The topic at Integrating Azure AD into an ASP.NET Core web app needs (I think) one touch-up: I moved the AD settings to the appsettings.json file so that they would get picked up automatically by the CreateDefaultBuilder. Where the topic talks about opening the config.json file, it should say to make those settings changes in the appsettings.json file. The rest of it is probably ok, but I'd have to take a closer look to know for sure.

Calling a ASP.NET Core Web API from a WPF application using Azure AD

In the sample, the TodoListClient app is netfx 4.5 and the TodoListService app is a 1.0 project.json-based Core app. Also, the topic mentions using VS2015.

Calling a web API in an ASP.NET Core web application using Azure AD

The whole sample (two apps) is 1.0 project-json-based. The text of the topic is also calling for VS2015.

@Rick-Anderson
Copy link
Contributor Author

@jmprieur what's the state of this?

@Rick-Anderson Rick-Anderson modified the milestones: Sprint 127 (11/11/17 - 12/01/17), Sprint 129 (ends 1/5/2018) Dec 5, 2017
@Rick-Anderson Rick-Anderson modified the milestones: Sprint 129 (ends 1/5/2018), Sprint 130 (ends 1/26/2018) Jan 9, 2018
@Rick-Anderson
Copy link
Contributor Author

@jmprieur what's the state of this?

@Rick-Anderson
Copy link
Contributor Author

@CamSoper I think you can close this once you finish your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri0 Urgent priority
Projects
None yet
Development

No branches or pull requests

3 participants