[release/9.0] Readd DiagnosticSource to KestrelServerImpl #60202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
BrennanConroy
added
ask-mode
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Open
3 tasks
|
Just merged 2 more fixes that should unblock CI |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Java test failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60129 to release/9.0
/cc @BrennanConroy
Readd DiagnosticSource to KestrelServerImpl
Description
During 8.0 we did a bunch of metrics work and accidentally removed
DiagnosticSourcesupport in Kestrel. We document how to monitor your app for bad requests and it doesn't work anymore.Fixes #58911
Customer Impact
Our docs on how to monitor your app for bad requests doesn't work anymore. Customers would instead need to rely on/add logging capturing for this scenario if they even notice that the feature is broken.
1st party as well as a couple customers have hit this.
Regression?
Regressed in .NET 8
Risk
Simple fix, added smoke test to verify, and did a manual test to check it works now.
Verification
Packaging changes reviewed?