Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Type.GetMemberWithSameMetadataDefinitionAs to speed up finding closed generic members #18355

Open
rolfbjarne opened this issue May 26, 2023 · 2 comments
Open

Use Type.GetMemberWithSameMetadataDefinitionAs to speed up finding closed generic members #18355

rolfbjarne opened this issue May 26, 2023 · 2 comments
Labels
enhancement The issue or pull request is an enhancement good first issue This is a good first issue for someone to start working with our code performance If an issue or pull request is related to performance
Milestone
.NET 10

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented May 26, 2023 •
edited
Loading

See comment here for more info: dotnet/runtime#86649 (comment)

Ref: https://learn.microsoft.com/en-us/dotnet/api/system.type.getmemberwithsamemetadatadefinitionas?view=net-6.0
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement performance If an issue or pull request is related to performance labels May 26, 2023
@rolfbjarne rolfbjarne added this to the .NET 8 milestone May 26, 2023
@ivanpovazan ivanpovazan mentioned this issue May 26, 2023
Closed
@ivanpovazan ivanpovazan mentioned this issue Jul 25, 2023
Closed
5 tasks
@filipnavara
Copy link
Member

Is this still relevant with #18421 ?

@rolfbjarne
Copy link
Member Author

Is this still relevant with #18421 ?

It doesn't hurt making the dynamic registrar faster too.

@rolfbjarne rolfbjarne added the good first issue This is a good first issue for someone to start working with our code label Sep 11, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Optimizations in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement good first issue This is a good first issue for someone to start working with our code performance If an issue or pull request is related to performance
Projects
None yet
Milestone
.NET 10
Development

No branches or pull requests
2 participants
@rolfbjarne @filipnavara