NullReferenceException throws on Windows when setting Cookies on .NET MAUI WebView #24846
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
issue-18452
branch
from
7fa653b
to
e767611
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @PureWeen , |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -366,6 +371,10 @@ void OnCoreWebView2Initialized(WebView2 sender, CoreWebView2InitializedEventArgs | |||
| if (Handler is WebViewHandler handler) | |||
| { | |||
| sender.UpdateUserAgent(handler.VirtualView); | |||
| if (handler.PlatformView.Source is not null) | |||
There was a problem hiding this comment.
Could simplify the code using directly sender instead handler.PlatformView.
For example:
if(sender.Source is not null)
There was a problem hiding this comment.
Could simplify the code using directly
senderinsteadhandler.PlatformView. For example:
if(sender.Source is not null)
Hi @jsuarezruiz,
We have simplified the source null condition based on your suggestion.
| Label label = new Label(); | ||
| label.AutomationId = "Label"; | ||
|
|
||
| const string url = "https://httpbin.org/#/Cookies/get_cookies"; |
There was a problem hiding this comment.
Can we use a msft or dotnet url here?
There was a problem hiding this comment.
Can we use a msft or dotnet url here?
Hi @PureWeen ,
We have used the Microsoft Learn documentation URL: https://learn.microsoft.com/en-us/dotnet/.
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -366,6 +371,10 @@ void OnCoreWebView2Initialized(WebView2 sender, CoreWebView2InitializedEventArgs | |||
| if (Handler is WebViewHandler handler) | |||
| { | |||
| sender.UpdateUserAgent(handler.VirtualView); | |||
| if (sender.Source is not null) | |||
| { | |||
| handler.SyncPlatformCookies(handler.PlatformView.Source.ToString()).FireAndForget(); | |||
There was a problem hiding this comment.
I would expect here
| handler.SyncPlatformCookies(handler.PlatformView.Source.ToString()).FireAndForget(); | |
| handler.SyncPlatformCookies(sender.Source.ToString()).FireAndForget(); |
or not?
There was a problem hiding this comment.
I would expect here
or not?
Hi @MartyIX ,
We have also updated the method for retrieving the SyncPlatformCookies source url.
…er platform view.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Root Cause
While setting a cookie in MAUI WebView, CoreWebView2 is null before the CoreWebView2Initialized event triggered.
Description of Change
Added the null condition for CoreWebView2 property while sync platform cookie method.
Issues Fixed
Fixes #18452
Validated the behaviour in the following platforms
Output images
Before changes
After changes
