Fix for unable to select a tab after backing out of a page and returning. #25011
Conversation
…elected property of the CurrentPage.
…opertyChanged for IsSelected.
…into fix-24741
|
Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
@PureWeen, Unfortunately, I'm unable to include a test case for the fix, as it's not possible to add an automation ID for the tab title. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Added UITest. |
|
/azp-run |
@jsuarezruiz, Thank you for your effort in adding and committing the test case for this complex scenario. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
||
| [Test] | ||
| [Category(UITestCategories.TabbedPage)] | ||
| public void SelectTabAfterNavigation() |
There was a problem hiding this comment.
@PureWeen, I have updated Screenshot for this issue. Could you please validate it once and let me know if there are any further concerns.
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
||
| [Test] | ||
| [Category(UITestCategories.TabbedPage)] | ||
| public void SelectTabAfterNavigation() |
There was a problem hiding this comment.
Updated test, simplified. Now is easy to wait or tap elements using both, AutomationId or with the view text.
There was a problem hiding this comment.
@jsuarezruiz, Thank you for your effort in updating the test case for this complex scenario.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Root cause
When navigating back to the main page, the SelectedItem restores its old value instead of clearing it. As a result, when updating with the MapCurrentPage, it does not get updated properly.
Description of Issue Fix
The fix involves setting the SelectedItem property of the NavigationView to null in the disconnect handler to resolve the tab selection issue and setting IsSelected in the MapItemSource to true when page matches view.CurrentPage, addressing the background-related issue.
Also, the issue with the TitleColor of the TabbedPage not updating correctly has been resolved by triggering the PropertyChanged event for TitleColor within the IsSelected property.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #24741
Output
24741-BeforeFix.mp4
24741-AfterFix.mp4