-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Setting Switch Off State Color #25068
base: main
Are you sure you want to change the base?
Support for Setting Switch Off State Color #25068
Conversation
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include some UITests? For example, could use the VerifyScreenshot
method to validate colors with snapshots.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(33,43): error RS0016: Symbol 'OffColorProperty' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(55,4): error RS0016: Symbol 'OffColor.get' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(56,4): error RS0016: Symbol 'OffColor.set' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
0 Warning(s)
3 Error(s)
19c941c
to
eb601dc
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The public API for the Tizen platform has been added. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
public void VerifySwitchOffColor() | ||
{ | ||
App.WaitForElement("Switch"); | ||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshots. Already available on the latest build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added snapshots for all platforms
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@PureWeen This should retarget to |
Description of Change
Currently, we can only change the track color for the switch in the "on" state. Support for changing the track color in the "off" state has now been added. A new API called OffColor has been implemented for the switch, allowing us to change the track color when the switch is off as well.
Issues Fixed
Fixes #15695
Tested the behaviour in the following platforms