Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set title on maui-blazor template window #25387

Closed
wants to merge 3 commits into from
Closed

Set title on maui-blazor template window #25387

wants to merge 3 commits into from

Conversation

Eilon
Copy link
Member

@Eilon Eilon commented Oct 18, 2024

Description of Change

Fix the .NET MAUI Blazor templates to have text in the title bar.

Issues Fixed

Fixes #25338

@Eilon Eilon marked this pull request as ready for review October 18, 2024 17:31
@Eilon Eilon requested a review from a team as a code owner October 18, 2024 17:31
@Eilon Eilon mentioned this pull request Oct 18, 2024
Closed
@Eilon Eilon added the area-templates Project templates, Item Templates for Blazor and MAUI label Oct 18, 2024
@Eilon Eilon mentioned this pull request Oct 18, 2024
Closed
@Eilon
Copy link
Member Author

Eilon commented Oct 19, 2024

Confirmed this has the right behavior in both Blazor Hybrid templates.

@rmarinho
Copy link
Member

Do we want in GA if so please target release/9.0.1xx, or else target main for net9 sr1

PureWeen
PureWeen requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#25387 (comment)

@Eilon Eilon changed the base branch from net9.0 to release/9.0.1xx October 21, 2024 18:08
@Eilon Eilon requested a review from a team as a code owner October 21, 2024 18:08
@Eilon Eilon requested review from mattleibow and removed request for a team October 21, 2024 18:08
@Eilon Eilon changed the base branch from release/9.0.1xx to net9.0 October 21, 2024 18:09
@Eilon
Copy link
Member Author

Eilon commented Oct 21, 2024

Replaced by #25426

@Eilon Eilon closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWeen PureWeen PureWeen requested changes

@jfversluis jfversluis Awaiting requested review from jfversluis

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-templates Project templates, Item Templates for Blazor and MAUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eilon @rmarinho @PureWeen