[gh actions] use "inclusive heat sensor" v0.1.1 #25532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #25389 Context: https://github.com/jonathanpeppers/inclusive-heat-sensor/releases/tag/v0.1.1 The version of the action in #25389 had an issue where a non-zero exit code could make the step fail. This would trigger a GitHub notification for the commenter. So, to avoid that, the v0.1.1 release: * Uses `continue-on-error: true` in the step that runs the action. * Explicitly `exit 0` in powershell, this was the true cause of the non-zero exit code. Note that we're still testing out this idea, our goal is to run this silently to decide how useful this will be. I also made this no longer run on `pull_request` reopen, as this event doesn't make sense.
|
@rmarinho if you want, we can test this out on Monday (or when you have free time). We'll want to undo what you did to disable the action last week. Thanks! |
rmarinho
approved these changes
Oct 25, 2024
|
This is a test. What happens if I paste a comment like: Update 1 |
|
Comment above rated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #25389
Context: https://github.com/jonathanpeppers/inclusive-heat-sensor/releases/tag/v0.1.1
The version of the action in #25389 had an issue where a non-zero exit code could make the step fail. This would trigger a GitHub notification for the commenter.
So, to avoid that, the v0.1.1 release:
Uses
continue-on-error: truein the step that runs the action.Explicitly
exit 0in powershell, this was the true cause of the non-zero exit code.Note that we're still testing out this idea, our goal is to run this silently to decide how useful this will be.
I also made this no longer run on
pull_requestreopen, as this event doesn't make sense.