Port FxCop rule CA1010: CollectionsShouldImplementGenericInterface

[ghost]

Title: Collections should implement generic interface

Description:

To broaden the usability of a collection, implement one of the generic collection interfaces. Then the collection can be used to populate generic collection types.

Dependency: None

Notes:

[jinujoseph]

Analyzer is complete , pending fixer

[jamesqo]

I'll implement the fixer. @mavasani Could you tag me?

[jamesqo]

Some thoughts I had while writing the fixer:

• Should we offer to implement IReadOnlyList<T> / IReadOnlyCollection<T> in addition to generic IList/ICollection?
• I don't think there's a good way to tell what the generic type should be. Should we put the user in a rename session for the type argument?

public class Collection : ICollection, ICollection<[|object|]>
{
    public void CopyTo([|object|][] array, int arrayIndex) { ... }

    // All of the other 'object' occurrences are highlighted
}

• How do I unit test a rename session? (I'm calling it "rename session" but I forgot if that was the actual name. It's the thing where you press tab to complete an event handler and something like this happens

)