Some ASP.NET Core 10.0 dlls are not R2R compiled

[tmds]

As part of our test suite, we have a test that checks .NET's dlls are R2R compiled.

That test is failing for these ASP.NET Core 10.0 dlls:

Microsoft.AspNetCore.Metadata.dll
Microsoft.AspNetCore.ResponseCaching.Abstractions.dll

To determine whether the assembly is R2R we check PEHeaders.CorHeader.ManagedNativeHeaderDirectory.Size != 0 (cfr #1802 (comment)).

The check is passing for the other ASP.NET Core dlls. The two dlls that fail don't have much in them (some interface definitions).

I wonder if there has been a change to crossgen which would causes these dlls to be skipped for R2R?

The check passes for the 9.0 version of these dlls.

cc @jkoritzinsky @jkotas @omajid @nicrowe00

[jkotas]

I wonder if there has been a change to crossgen which would causes these dlls to be skipped for R2R?

I am not aware of any.

Do you see crossgen2 running on these assemblies in your build log? Does it produce any errors?

[tmds]

I don't see any errors in the log, and I found:

Emitting R2R PE file: /home/tester/dotnet/src/aspnetcore/artifacts/obj/Microsoft.AspNetCore.App.Runtime.Composite/Release/fedora.40-x64/R2R/Microsoft.AspNetCore.Metadata.dll

I took a look in the aspnetcore repo, and I didn't find a reason why this project would be treated differently from the others (which are passing the R2R check).

I'll do a local build so I can see if any Microsoft.AspNetCore.Metadata.dll in aspnetcore artifacts pass the check.

[EgorBo]

@tmds are you sure that the assembly has functions to prejit? if it's only a bunch of interfaces/facades, then presumably there is no work for R2R. From a quick look, Microsoft.AspNetCore.Metadata looks to be so - isn't just an assembly with just two interfaces?

[jkotas]

@tmds are you sure that the assembly has functions to prejit?

crossgen2 will produce R2R image even if there is no code to compile. R2R image has other good stuff in addition to the code, for example indexes for some metadata tables.

[tmds]

I had also assumed something might have changed which made crossgen2 skip these assemblies which is why I created the issue in this repo.

Looking at the assemblies produced during the vmr aspnetcore build, there is a crossgenned Microsoft.AspNetCore.Metadata.dll at artifacts/obj/Microsoft.AspNetCore.App.Runtime.Composite/Release/linux-x64/R2R which is the one that I saw in the binlog, and which confirms the dll can be crossgenned.

There isn't one at artifacts/obj/aspnetcore-sfx/Release/linux-x64/R2R, which is where the shared framework one is probably supposed to be.

I'm going to close this issue and create one in aspnetcore repo instead.

[tmds]

aspnetcore issue: dotnet/aspnetcore#60174.