Remove ".Core" from namespaces #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`System.Private.Windows` is really the root namespace. `Core` is just the name of the core assembly for `Sytem.Private.Windows`. We already have a second assembly (GdiPlus), and may have others in the future.
KlausLoeffelmann
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12839 +/- ##
====================================================
+ Coverage 76.13611% 96.97774% +20.84162%
====================================================
Files 3240 1212 -2028
Lines 642343 356885 -285458
Branches 47270 5514 -41756
====================================================
- Hits 489055 346099 -142956
+ Misses 149742 9950 -139792
+ Partials 3546 836 -2710
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Private.Windowsis really the root namespace.Coreis just the name of the core assembly forSytem.Private.Windows. We already have a second assembly (GdiPlus) and may have others in the future.Microsoft Reviewers: Open in CodeFlow