Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCleanUp] Addressing IDE warnings #10185

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

siagupta0202
Copy link
Contributor

@siagupta0202 siagupta0202 commented Dec 17, 2024

Fixes #10272

Description

This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.

The current changes addresses the following Errors/Warnings in the src folder of WPF:

IDE0150: Prefer 'null' check over type check

Customer Impact

None

Regression

None

Testing

Local build pass

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 17, 2024
@siagupta0202 siagupta0202 marked this pull request as ready for review December 17, 2024 09:46
@siagupta0202 siagupta0202 requested review from a team as code owners December 17, 2024 09:46
@siagupta0202 siagupta0202 changed the title Addressing IDE0150 .editorconfig issues [StyleCleanUp] Addressing IDE warnings Dec 17, 2024
himgoyalmicro
himgoyalmicro previously approved these changes Dec 18, 2024
harshit7962
harshit7962 previously approved these changes Dec 18, 2024
Copy link
Member

@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himgoyalmicro himgoyalmicro merged commit f15a1fd into dotnet:main Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE0150: Prefer 'null' check over type check
3 participants