Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + keyboard arrow does not include all files inside selection #13

Open
WhiteChairFromIkea opened this issue Jun 30, 2021 · 4 comments

Comments

@WhiteChairFromIkea
Copy link
Contributor

Description

One can select several files with Shift + Arrow keys in the keyboard. The last marked file is always excluded from selection, which looks like a bug.

See screencast:
https://youtu.be/QwWD9bJh1ZI

Steps to reproduce

  1. Have 4 files inside folder;
  2. Select (mouseclick) first (upper most) file;
  3. Shift + arrow down on keyboard 3 times;
  4. Now copy paste selection somewhere;

Expected

Four files pasted inside destination folder.

Actual

Only three (1 .. 3) files are pasted. 4th file was not included inside selection. But it was marked in step #3.

Double Commander
Version: 0.9.10 beta
Revision: 9640M
Build date: 2021/01/10
Lazarus: 2.0.8.0
FPC: 3.0.4
Platform: x86_64-Win64-win32/win64
OS version: Windows 10 Home 2009 x86_64

@TheNicker
Copy link
Member

There's a difference between the file entries selected for file operation and the selected cursor highlight.

Pressing [Shift + Down Arrow] on the keyboard for 4 times should be the correct way to select 4 files for file operation and should solve the issue, please notice that the text color of the last file entry is also changed.

Pressing further Shift + arrow should toggle selection of the last file for file operation

@WhiteChairFromIkea
Copy link
Contributor Author

WhiteChairFromIkea commented Jul 2, 2021

Thank you for the answer, but I guess I don't understand it completely:

Pressing further Shift + arrow should toggle selection of the last file for file operation

  • Is this "as designed", not a bug? It differs from other explorers very much, makes me always double check (time waste and a little bit of stress) if all intended files are selected: first file, and the last one (selected for file operation). I work with three explorers simultaneously (ms explorer because some apps forces me to, "free commander" - because it handles drag n drop operations well from other apps, and DC as my main explorer (but it fails on drag and drop operations from bitvise SSH app (https://www.bitvise.com/ssh-client-download)). This switching between three browsers is very error-prone :(
  • Just a note: This is what prevents me to use DC as my main browser: Failing drag and drop operations #14

Switching off "Use frame cursor" option helps to see selected files for file operation very well, but cursor highlight frame can be barely seen (also would slow down a workflow):

4921M
50352

Would it be possible to:
a) Add option to switch between "ms explorer.exe" kind of selection (shift + arrow selects everything under cursor);
b) Make "Cursor border" thickness (pixel count configurable. Thick selection cursor frame would help here, and probably solve the issue.

Solution a) would be preferred :)

@TheNicker
Copy link
Member

TheNicker commented Jul 2, 2021

Function wise, Double commander is based on total commander so the current behavior of the Shift Down/Up arrow is a convention that most users ( I presume) are used too which is the current behavior as design. This was at times when explorer was barely usable, today it's much better.

Add option to switch between "ms explorer.exe" kind of selection (shift + arrow selects everything under cursor)

I don't think it's feasible, double commander doesn't use multi cursor selection like explorer which has its benefits.

I've just tested a clean version of double commander with default settings and the selected files seem clear without using inverted selection or frame cursor, a file that is marked red is selected otherwise it's not selected.

@Neustradamus
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants