Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove attribute highlighting? #19

Open
ge0dem0 opened this issue Oct 31, 2024 · 11 comments
Open

How to remove attribute highlighting? #19

ge0dem0 opened this issue Oct 31, 2024 · 11 comments

Comments

@ge0dem0
Copy link

ge0dem0 commented Oct 31, 2024

Hey fellow vampires,
I would like to remove or change the color of the attribute highlighting. As you can see the highlight color and the cursor color are almost the same which is disturbing my workflow.
Thanks in advance
Bildschirmfoto 2024-10-31 um 12 36 14

@Otterpocket
Copy link
Contributor

bit odd innit.

Have you noticed this outside of vue files?

Does this happen in any other themes when using the same file ?

@ge0dem0
Copy link
Author

ge0dem0 commented Nov 4, 2024

I made some tests and it just happends in vue files. I also have the highlight effect in all other themes and "Zed preview" shows the same effect.

@ge0dem0
Copy link
Author

ge0dem0 commented Nov 4, 2024

The effects gets disturbed when the syntax box appers

Bildschirmfoto 2024-11-04 um 16 14 28

@Otterpocket
Copy link
Contributor

When it happens in other themes does it cause the same usability issue you are seeing in Dracula ?

@ge0dem0
Copy link
Author

ge0dem0 commented Nov 5, 2024

Mostly the cursor has a different color therefore the issue is not that interfering.

Bildschirmfoto 2024-11-05 um 12 24 04

@Otterpocket
Copy link
Contributor

Otterpocket commented Nov 5, 2024

hmm, I feel like its a problem with the syntax highlights in zed for vue. You may want to create an issue here https://github.com/zed-industries/zed/issues.

If I get time this week, I can try and find the part of theme that is doing it so you can override.

We can keep this ticket open for now.

@Otterpocket
Copy link
Contributor

Ok, I see the issue. In Zed each player has a theme, and in that theme each has its own cursor colour. Player 1 happens to have the same colour as that syntax highlight.

I'll write a fix to make it play nicer and let you know when it's pushed.

@Otterpocket
Copy link
Contributor

this is the things you can override to fix it:

editor.document_highlight.read_background

However the problem is that Zed takes that initial color and messes with it for the multi layers of highlighting.

So even if the colour is changed it produces this:
image

Here's a the actual issue:
zed-industries/zed#17890

Sorry, but there is no fix I can come up with that doesn't break lots of other syntax highlighting.

I suggest overriding the above style until zed fixes the wider issue.

@ge0dem0
Copy link
Author

ge0dem0 commented Nov 5, 2024

Too bad. But thanks a lot @Otterpocket for taking a closer look into this!

@ge0dem0
Copy link
Author

ge0dem0 commented Nov 5, 2024

Just in case someone is running into the same issue:
Thanks to @Otterpocket I changed editor.document_highlight.read_background to #bd93f90D. This last two digits represent the opacity and is now at 5% which looks like this:
Bildschirmfoto 2024-11-05 um 15 02 25

You can check the HEX opacity values here for example: https://drawne.com/hex-opacity/

@Otterpocket
Copy link
Contributor

Just in case someone is running into the same issue: Thanks to @Otterpocket I changed editor.document_highlight.read_background to #bd93f90D. This last two digits represent the opacity and is now at 5% which looks like this: Bildschirmfoto 2024-11-05 um 15 02 25

You can check the HEX opacity values here for example: https://drawne.com/hex-opacity/

The only issue you will find with that change is you will no longer be able to see the highlighting on other elements like tags/brackets and " for example.

It's a bit of a Whac-A-Mole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants