Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replicaof <myself> flushes the dataset #4501

Open
romange opened this issue Jan 24, 2025 · 1 comment
Open

replicaof <myself> flushes the dataset #4501

romange opened this issue Jan 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@romange
Copy link
Collaborator

romange commented Jan 24, 2025 •
edited
Loading

replicaof localhost 6379 fails but before that it flushes whatever data it has.

Currently the replication flow is designed in such way,
that we first flush the dataset and only then check if handshake succeeds.
Ideally we should first succeed with the handshake and only then flush the database.
@romange romange added the bug Something isn't working label Jan 24, 2025
@C-mmon
Copy link

C-mmon commented Jan 24, 2025

Can i help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romange @C-mmon