feat: delete persistent cache task from peer #3786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes various improvements and bug fixes across multiple files, primarily focusing on enhancing the
PeerManager
interface and related functionalities. The most important changes include adding new methods to thePeerManager
interface, updating logging for better error tracking, and modifying theDeletePersistentCacheTask
function to ensure proper cleanup.Enhancements to
PeerManager
interface:LoadAllIDsByTaskID
andLoadAllIDsByHostID
methods to thePeerManager
interface to retrieve peer IDs by task ID and host ID respectively. [1] [2]Logging improvements:
Refactoring in
scheduler/service/service_v2.go
:DeletePersistentCachePeer
to delete the persistent cache task from the peer and handle potential errors during the deletion process.DeletePersistentCacheTask
to ensure all related peers are properly deleted and their associated tasks are removed from the peers.Minor changes:
scheduler/job/job.go
for consistency and clarity. [1] [2]go.mod
.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist