Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e/v2): add transfer-from-dfdaemon option for dfget test case #3832

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces new test contexts for downloading files using dfget with the transfer-from-dfdaemon option in the test/e2e/v2/dfget_test.go file. The changes include adding tests for 1MiB and 10MiB file downloads.

New test contexts for dfget:

  • Added context for downloading a 1MiB file using dfget with transfer-from-dfdaemon option. This includes setup and teardown steps, as well as validation of the downloaded file's SHA256 checksum.
  • Added context for downloading a 10MiB file using dfget with transfer-from-dfdaemon option. This includes setup and teardown steps, as well as validation of the downloaded file's SHA256 checksum.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 13, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 13, 2025
@gaius-qi gaius-qi self-assigned this Feb 13, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 13, 2025 04:19
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.80%. Comparing base (3973340) to head (5b8b8e6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #3832       +/-   ##
=========================================
+ Coverage      0   35.80%   +35.80%     
=========================================
  Files         0      337      +337     
  Lines         0    38991    +38991     
=========================================
+ Hits          0    13961    +13961     
- Misses        0    24111    +24111     
- Partials      0      919      +919     
Flag Coverage Δ
unittests 35.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 337 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 8c684ee into main Feb 13, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/transfer-from-dfdaemon branch February 13, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants