Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e/v2): add test cases for dfcache #3833

Merged
merged 1 commit into from
Feb 14, 2025
Merged

test(e2e/v2): add test cases for dfcache #3833

merged 1 commit into from
Feb 14, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 13, 2025

Description

This pull request introduces a new function to calculate the SHA-256 checksum for a task by accessing a persistent cache. The most important change is the addition of the new function CalculateSha256ByPersistentCacheTaskID.

New functionality:

  • test/e2e/v2/util/task.go: Added CalculateSha256ByPersistentCacheTaskID function to calculate the SHA-256 checksum for a task by accessing a persistent cache path. This function iterates over the provided pods, checks if the content path exists, and computes the SHA-256 checksum if the path is found.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 13, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 13, 2025
@gaius-qi gaius-qi self-assigned this Feb 13, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 13, 2025 08:30
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.83%. Comparing base (3973340) to head (1ef15f6).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #3833       +/-   ##
=========================================
+ Coverage      0   35.83%   +35.83%     
=========================================
  Files         0      337      +337     
  Lines         0    38991    +38991     
=========================================
+ Hits          0    13973    +13973     
- Misses        0    24098    +24098     
- Partials      0      920      +920     
Flag Coverage Δ
unittests 35.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 337 files with indirect coverage changes

@gaius-qi gaius-qi force-pushed the feature/dfcache branch 2 times, most recently from 449b355 to 2a03158 Compare February 13, 2025 09:21
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 6a879ab into main Feb 14, 2025
27 checks passed
@chlins chlins deleted the feature/dfcache branch February 14, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants