Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_custom_root_ca should be mocked #2

Open
sidneywidmer opened this issue Feb 25, 2021 · 0 comments
Open

_custom_root_ca should be mocked #2

sidneywidmer opened this issue Feb 25, 2021 · 0 comments

Comments

@sidneywidmer
Copy link
Contributor

Currently the _custom_root_ca parameter in the GoogleConfig class is only used for clean unittests. A careless developer could use this in a production environment which would, in special circumstances, lead to invalid attestations passing the verification. In the real world it would mostly lead to no attestation being verified at all - even valid ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sidneywidmer