Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskbar size does not update after changing display scaling percentage #151

Open
xoascf opened this issue Nov 8, 2021 · 11 comments
Open

Comments

@xoascf
Copy link
Collaborator

xoascf commented Nov 8, 2021

The theme has to be changed manually to be updated, it is not automatic.

@xoascf xoascf changed the title Taskbar size does not update after changing the system scaling Taskbar size does not update after changing display scaling percentage Nov 8, 2021
@dremin
Copy link
Owner

dremin commented Nov 8, 2021

I'm not able to reproduce this, have you set any compatibility options on RetroBar.exe by chance?

@xoascf
Copy link
Collaborator Author

xoascf commented Nov 9, 2021

I'm not able to reproduce this, have you set any compatibility options on RetroBar.exe by chance?

No compatibility options have been set.

In a clean installation of Windows 11, the taskbar does not update its size like the Properties window or the stock taskbar does.
Artifact from: https://github.com/dremin/RetroBar/actions/runs/1437230491

Stock taskbar behaviour:

2021-11-08.19-49-13.130.mp4

RetroBar behaviour:

2021-11-08.20-07-47.130.mp4

@dremin
Copy link
Owner

dremin commented Nov 9, 2021

Thanks for the videos! Interesting, using the same settings as you I can reproduce this on Windows 11, but not Windows 10. I'll have to start debugging this further.

@dremin
Copy link
Owner

dremin commented Nov 27, 2021

Okay, this is really strange. Windows doesn't send WM_DPICHANGED to the taskbar window for some reason, but it does if we change our size. I'm still working through trial and error to figure out what about the taskbar window causes this.

@xoascf
Copy link
Collaborator Author

xoascf commented Nov 28, 2021

Hey, check out this implementation:
https://github.com/PhilipRieck/WpfAppBar

It works fine for DPI changes in Windows 11, but everything else doesn't work as well as the ManagedShell implementation.

@dremin
Copy link
Owner

dremin commented Mar 29, 2022

I am seeing DPI changes take effect again with Insider build 22581. However, I see #304 when that happens. Are you seeing the same?

@xoascf
Copy link
Collaborator Author

xoascf commented Mar 29, 2022

I am seeing DPI changes take effect again with Insider build 22581. However, I see #304 when that happens. Are you seeing the same?

Interesting, the taskbar goes up and down in position when changing DPI and then down to the bottom edge of the screen, for some reason it worked for me to change the DPI with RetroBar at login (the taskbar was able to adapt to the selected DPI), but then it didn't (I downloaded and ran the new version).

@vchirikov
Copy link
Contributor

I don't see the retrobar at 200% scale on the third monitor at all :(
If I change scale to 100% and restart the app, it works, but doesn't update the size of taskbar after a scale change.

@dremin
Copy link
Owner

dremin commented Nov 21, 2024

@xoascf I believe this is fixed by #945 when changing DPI on the primary display, as doing that broadcasts a TaskbarCreated message.

@xoascf
Copy link
Collaborator Author

xoascf commented Nov 21, 2024

@dremin I just tried again on Windows 11 with the latest two Insider builds, both of which fail to update the scale for RetroBar and still require reloading the parent or main theme (not sure if this happens on stable builds).

Additional info: No tweaks enabled (no OpenGlass, no ExplorerBlurMica, no Windhawk, no StartAllBack, no patched styles, still the same).

whynotupdatescale.mp4

@dremin
Copy link
Owner

dremin commented Nov 21, 2024

@xoascf Oh well, thanks for testing! I wonder why my configuration is causing that message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants