Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors #43

Open
zaaack opened this issue Mar 10, 2019 · 1 comment
Open

Type errors #43

zaaack opened this issue Mar 10, 2019 · 1 comment

Comments

@zaaack
Copy link

zaaack commented Mar 10, 2019

  1. multiple difinition of OrderSide
  2. clOrdID is string, not number
  3. order.account is number, not string
  4. orderResponse.transactTime 的类型 和 timestamp 不一致,transactTime 是 Date 而不是 string
    "transactTime": "2019-03-09T12:16:23.853Z",
    "timestamp": "2019-03-09T12:16:23.853Z"
    ...
@zlq4863947
Copy link
Member

1、 multiple difinition of OrderSide

OrderSide 程序目前有2处定义: bitmex交易所的OrderSide、以及dripjs框架的OrderSide

bitmex交易所的OrderSide

  • 以后框架搭出来后会陆续增加其他交易的支持,这里的OrderSide是bitmex交易所定义的OrderSide,与dripjs解耦分离。
  • dripjs想调用bitmex交易所的OrderSide时
import { Bitmex } from '@dripjs/exchanges';
const bitmexOrderSide: Bitmex.OrderSide;
...
  • bitmex交易所单独作为模块调用OrderSide时
import { OrderSide } from 'dripjs-bitmex';
const bitmexOrderSide: OrderSide;
...

所以并不是重复的问题,而是两种完全不相关的东西。

2、 clOrdID is string, not number

3、order.account is number, not string

4、orderResponse.transactTime 的类型 和 ti...

嗯 可能是个bug,我还没检查,现在先优先完成大的功能框架,这个以后有时间去修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants