Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Delete button is really dangerous #35

Closed
Tronic opened this issue Aug 31, 2021 · 1 comment · Fixed by #37
Closed

The Delete button is really dangerous #35

Tronic opened this issue Aug 31, 2021 · 1 comment · Fixed by #37

Comments

@Tronic
Copy link

Tronic commented Aug 31, 2021

There is no confirmation when the delete button is pressed, and even entire folders can be deleted with a single click. Since the button is between download and actions buttons, on each row, misclicks are all too easy.

I suggest reworking the logic:

  1. Remove per-file action buttons, add buttons on title toolbar instead (similar to other file managers)
  2. Add a confirmation to deletion (the dialog should display how many files etc. are being removed)
  3. Allow selection of multiple files and select all, such that bulk deletion/download/etc. become feasible

Previously reported at silverwind/droppy#391 but never fixed, closely related to #16 too.

@markhughes
Copy link
Collaborator

Good idea. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants