Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to folders with spaces in their names not working #51

Open
Tronic opened this issue Jan 30, 2022 · 2 comments
Open

Back to folders with spaces in their names not working #51

Tronic opened this issue Jan 30, 2022 · 2 comments
Labels
kind/bug Something isn't working status/in-progress

Comments

@Tronic
Copy link

Tronic commented Jan 30, 2022

Browsing any subfolder or file within a folder that has spaces in its name and hitting back on browser takes me back to Droppy root folder, not to the parent folder as expected. If there are no spaces, the back function works as it should. As a workaround, clicking the Droppy header breadcrumb of the right folder takes me there even when there are spaces.

So, the navigation history management doesn't do correct escaping/unescaping of %20, an invalid URL is produced and Droppy reverts to showing the root? I did not verify whether that is what is happening but would appreciate if you could fix this.

P.S. I am running many Droppy instances for myself and for two companies now. One of them is a public one at https://drop.zi.fi/ and despite sharing the link on some darker corners of the Internet I have not seen any relevant abuse yet (but the service runs in a sandbox and keeps logs, just in case). Excellent support for media files too! In case you accept donations, as I offered before, I would still wish to contribute.

@markhughes markhughes added kind/bug Something isn't working status/ready-to-work-on labels Feb 3, 2022
@vahtos
Copy link
Contributor

vahtos commented Jan 26, 2024

Cannot reproduce this issue. Tried in Firefox and Chrome.

@markhughes
Copy link
Collaborator

This issue is an encode/decode issue, it's not handled (anywhere).

This issue is littered throughout and I'll resolve after #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/in-progress
Projects
None yet
Development

No branches or pull requests

3 participants