Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with redirects #19

Open
blackwiz4rd opened this issue Jan 10, 2025 · 2 comments
Open

Issue with redirects #19

blackwiz4rd opened this issue Jan 10, 2025 · 2 comments

Comments

@blackwiz4rd
Copy link

blackwiz4rd commented Jan 10, 2025 •
edited
Loading

In case you pass an ISIN which does not exist to load_chart, the API call might make a redirect so I suggest adding

allow_redirects=False,

on the requests.
@druzsan
Copy link
Owner

druzsan commented Jan 18, 2025

Hi @blackwiz4rd, can you give me an example of such to be able to reproduce and check the behavior?

@blackwiz4rd
Copy link
Author

Hello,
I'm unable to reproduce it. Don't know why. I think I got this issue while not using your plugin but with my custom scraper.
Anyway, adding

allow_redirects=False,

should not cause any issues and might be beneficial for future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blackwiz4rd @druzsan