-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionalUpdate is ignored if requiredUpdate is present #30
Comments
Hi @kc8nod , I have been checking the operation of the framework and it makes sense that the optionalUpdate is ignored if requiredUpdate is present, it is how Gandalf (Android equivalent) works too. There is a slight difference in the operation comparing to Gandalf: the alert has more priority over the optionalUpdate in Gandalf and in the LaunchGate it is just the opposite. Current LaunchGate (iOS) logic: I'll create a new issue to change the iOS behaviour to be the same to the Android one (#35). Please, @dtrenz , can you check if what I state here makes sense to you? If so, you can close this issue in my opinion. Thanks a lot ! Rodrigo |
Imagine the case where requiredUpdate is 2.0 and optionalUpdate is 4.0 Now suppose that a user is running version 3.0. |
Hi again @kc8nod , Yes, you are right; but I have been testing with the exampleApp included in the project and this issue is also fixed with the Pull Request #36 which fixes also the issue #35 so that it can also be closed. I mean: the example you provide with your comment works as expected, i.e., the user sees the prompt to upgrade to 4.0. You can test it also and if you find any inconsistency in the operation, you can open a new issue. Thanks for the notice anyway ;) Let's wait for @dtrenz confirmation about all of this we are discussing. Best regards, Rodrigo |
If "requiredUpdate" is present in the JSON, then "optionalUpdate" is ignored.
Likewise if "optionalUpdate" is present, then "alert" is ignored.
The text was updated successfully, but these errors were encountered: