fix: select error node

co/coordinator.go

@@ -85,7 +85,6 @@ func (c *Coordinator) handleCandidate(hc *headCandidate) {
 
 	if c.sel.Weight(addr) == 0 {
 		log.Infof("skip zero weight node %s ", addr)
-		hc.done()
 		return
 	}
 	clog := log.With("node", addr, "h", hc.ts.Height(), "w", hc.weight, "drift", time.Now().Unix()-int64(hc.ts.MinTimestamp()))
@@ -99,7 +98,6 @@ func (c *Coordinator) handleCandidate(hc *headCandidate) {
 		next := hc.ts
 
 		c.head = hc.ts
-		hc.done() //cache update must after set head
 		c.weight = hc.weight
 		c.nodes = append(c.nodes[:0], addr)
 
@@ -120,7 +118,6 @@ func (c *Coordinator) handleCandidate(hc *headCandidate) {
 		return
 	}
 
-	defer hc.done() //update cache although this head is not the best
 	if c.head.Equals(hc.ts) {
 		contains := false
 		for ni := range c.nodes {

co/ctx.go

@@ -35,7 +35,6 @@ type headCandidate struct {
 	node   *Node
 	ts     *types.TipSet
 	weight types.BigInt
-	done   func()
 }
 
 func newBlockHeaderCache(size int) (*blockHeaderCache, error) {

co/node.go

@@ -211,6 +211,8 @@ func (n *Node) reListen() (<-chan []*api.HeadChange, error) {
 }
 
 func (n *Node) applyChanges(lifeCtx context.Context, changes []*api.HeadChange) {
+	n.blkCache.add(changes)
+
 	idx := -1
 	for i := range changes {
 		switch changes[i].Type {
@@ -240,9 +242,6 @@ func (n *Node) applyChanges(lifeCtx context.Context, changes []*api.HeadChange)
 		node:   n,
 		ts:     ts,
 		weight: weight,
-		done: func() {
-			n.blkCache.add(changes)
-		},
 	}
 
 	slow := time.NewTicker(5 * time.Second)