Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to provide CA roots #29

Closed
kalafut opened this issue Dec 15, 2020 · 1 comment
Closed

Option to provide CA roots #29

kalafut opened this issue Dec 15, 2020 · 1 comment

Comments

@kalafut
Copy link

kalafut commented Dec 15, 2020

This SDK pins the root CA certificates:

duo_api_golang/duoapi.go

Line 154 in 0e07e9f

certPool.AppendCertsFromPEM([]byte(duoPinnedCert))
If the user has a proxy terminating TLS, the cert validation step will always fail. Would it be possible to allow optionally configuring these certs when creating a new DuoApi object?
@kalafut
Copy link
Author

kalafut commented Dec 15, 2020

I see this was addressed in a more recent version (#23). Thanks!

@kalafut kalafut closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalafut