Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Upload all images on MinIO S3 #34

Closed
Mulugruntz opened this issue Feb 9, 2024 · 0 comments · Fixed by #39
Closed

Events: Upload all images on MinIO S3 #34

Mulugruntz opened this issue Feb 9, 2024 · 0 comments · Fixed by #39
Assignees
Labels
feature New feature or request high priority to do immediately

Comments

@Mulugruntz
Copy link
Contributor

A follow-up to #28 .

The goal is to upload all images to our S3 bucket.

The scheme is event/<lang>/<YYYY>/<MM>/<filename>.

Example with this test image:
https://s3-api.dval.in/event/fr/2024/01/95de72899ba234747623aea05a36f796_5234945346975622605.gif
image

Also, at the same time, urlLocal should be removed and replaced by s3Resource, such as for the above example:

"s3Resource": "event/fr/2024/01/95de72899ba234747623aea05a36f796_5234945346975622605.gif",

I propose to not have the full URL in it, as changing the S3 DNS will mean that we'll have to change all the JSON's URLs.
But maybe that's not reasonable? As it would also make sense, in a future PR, to pre-compute the content with our S3. In that case, we'll need the full URL anyway.

If so, then we could have:

"s3Url": "https://s3-api.dval.in/event/fr/2024/01/95de72899ba234747623aea05a36f796_5234945346975622605.gif",
@Mulugruntz Mulugruntz self-assigned this Feb 9, 2024
@Mulugruntz Mulugruntz linked a pull request Feb 10, 2024 that will close this issue
@LudovicMalot LudovicMalot added feature New feature or request high priority to do immediately labels Feb 11, 2024
@LudovicMalot LudovicMalot moved this to In progress in Data Feb 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Data Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request high priority to do immediately
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants