Cop idea: Mind Transactions

[ydakuka]

Reference: https://github.com/toptal/active-job-style-guide#mind-transactions

Background processing of a scheduled job may happen sooner than you expect. Make sure to only schedule jobs when the transaction has been committed.

# bad - job may perform earlier than the transaction is committed
User.transaction do
  users_params.each do |user_params|
    user = User.create!(user_params)
    NotifyUserJob.perform_later(user)
  end
end

# good
users = User.transaction do
          users_params.map do |user_params|
            User.create!(user_params)
          end
        end
users.each { |user| NotifyUserJob.perform_later(user) }