New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cop idea: Prefer a consistent style for queues #17

Open

ydakuka opened this issue Sep 17, 2023 · 0 comments

ydakuka commented Sep 17, 2023

# bad
class SomeJob
  include Sidekiq::Job
  sidekiq_options queue: :low

  def perform
    # ...
  end
end

# good
class SomeJob < ApplicationJob
  include Sidekiq::Job
  queue_as :low

  def perform
    # ...
  end
end

# good
class SomeJob
  include Sidekiq::Job

  queue_as do
    paid = self.arguments.second

    !!paid ? :high : :low
  end

  def perform(post_id, paid)
    # ...
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment