Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for newer GitHub token format? #30

Open
kingthorin opened this issue Jan 5, 2022 · 1 comment
Open

Update for newer GitHub token format? #30

kingthorin opened this issue Jan 5, 2022 · 1 comment

Comments

@kingthorin
Copy link

If https://github.com/dxa4481/truffleHogRegexes/blob/master/truffleHogRegexes/regexes.json really is the base rule set for TruffleHog as stated on: https://github.com/trufflesecurity/truffleHog#customizing, then it should have a new entry that accommodates updated GitHub tokens.

Per https://github.blog/changelog/2021-03-31-authentication-token-format-updates-are-generally-available/

It seems like the existing GitHub regex uses the right charset. However, it doesn’t account for the new prefixes or length up to 255.

@kingthorin
Copy link
Author

kingthorin commented Jan 5, 2022

I’m happy to open a PR if there’s agreement on this.

Edit: looks like someone already tackled this, #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant