Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter for html #1192

Open
lookupdaily opened this issue Aug 21, 2023 · 2 comments
Open

Add formatter for html #1192

lookupdaily opened this issue Aug 21, 2023 · 2 comments

Comments

@lookupdaily
Copy link
Contributor

lookupdaily commented Aug 21, 2023

Currently we have no formatter in place for html files. We could add Prettier for this, but would need to make sure it does not conflict with JavaScript Standard

This would help us to keep our code consistent when editing html files, and reduce formatting changes on changes to existing files (if a developer uses a formatter locally).

There is currently a .prettierignore file which seems redundant. Would be good to remove this, use use it as part of this enhancement.

@yndajas
Copy link
Member

yndajas commented Aug 22, 2023

Could we just tell it to ignore .js files? Or alternatively switch to Prettier wholesale and drop Standard?

@lookupdaily
Copy link
Contributor Author

Yep, that's how we've done it on our current project (ignoring js files). If we binned standard, we'd need to use eslint anyway, as they have separate concerns, however standard covers formatting as well as rule checking i believe?

Prettier has guidance on integrating with eslint, but not standard.

@yndajas yndajas mentioned this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants