From 2a5f0bd7dd82525b5eab037ad82d02c6465835f4 Mon Sep 17 00:00:00 2001 From: "K. Shankari" Date: Tue, 27 Aug 2024 12:37:09 -0700 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20=20Move=20the=20ios=20scri?= =?UTF-8?q?pt=20fix=20to=20`before=5Fcompile`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was in `before_build` earlier, but that led to the changes from the script being overridden before the actual compile started https://github.com/e-mission/e-mission-docs/issues/1079#issuecomment-2311541336 https://github.com/e-mission/e-mission-phone/pull/1168#issuecomment-2313193479 https://github.com/e-mission/e-mission-phone/pull/1168#issuecomment-2313327905 https://github.com/e-mission/e-mission-phone/pull/1168#issuecomment-2313343892 https://github.com/e-mission/e-mission-phone/pull/1168#issuecomment-2313388338 Testing done: Before this change: ``` Done setting IPHONEOS_DEPLOYMENT_TARGET Overwriting existing resource file at platforms/ios/emission/Resources/GoogleService-Info.plist ^[[37mcordova-custom-config: Applied custom config from config.xml to /Users/kshankar/Desktop/data/e-mission/native_code_upgrade/platforms/ios/emission/emission-Info.plist^[[39m ``` After this change: ``` Overwriting existing resource file at platforms/ios/emission/Resources/GoogleService-Info.plist ^[[37mcordova-custom-config: Applied custom config from config.xml to /Users/kshankar/Desktop/data/e-mission/native_code_upgrade/platforms/ios/emission/emission-Info.plist^[[39m ... Done setting IPHONEOS_DEPLOYMENT_TARGET ... Touch /Users/kshankar/Desktop/data/e-mission/native_code_upgrade/platforms/ios/build/Debug-iphonesimulator/emission.app (in target 'emission' from project 'emission') cd /Users/kshankar/Desktop/data/e-mission/native_code_upgrade/platforms/ios /usr/bin/touch -c /Users/kshankar/Desktop/data/e-mission/native_code_upgrade/platforms/ios/build/Debug-iphonesimulator/emission.app ** BUILD SUCCEEDED ** ``` --- config.cordovabuild.xml | 2 +- .../ios/ios_change_deployment.js | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename hooks/{before_build => before_compile}/ios/ios_change_deployment.js (100%) diff --git a/config.cordovabuild.xml b/config.cordovabuild.xml index 3401b9b9b..858f7fd4d 100644 --- a/config.cordovabuild.xml +++ b/config.cordovabuild.xml @@ -37,7 +37,7 @@ - + diff --git a/hooks/before_build/ios/ios_change_deployment.js b/hooks/before_compile/ios/ios_change_deployment.js similarity index 100% rename from hooks/before_build/ios/ios_change_deployment.js rename to hooks/before_compile/ios/ios_change_deployment.js