Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor textanswers access control #2372

Open
jooooosef opened this issue Jan 14, 2025 · 0 comments
Open

Refactor textanswers access control #2372

jooooosef opened this issue Jan 14, 2025 · 0 comments
Labels
[C] Backend Focuses on backend implementation [P] Medium Medium priority [T] Refactoring Existing parts should become faster, more readable, or in any other way better.

Comments

@jooooosef
Copy link
Collaborator

jooooosef commented Jan 14, 2025

Taken from #2232 (comment), which also includes some pointers on a possible implementation approach.

In #2232, we needed information about whether a user would be allowed to see answers by categories (e.g. "general textanswers", "your own textanswers", ...) to dynamically enable buttons that show answers of those categories on a results page.

Our current framework for answer access permissions isn't able to answer those questions, as a workaround, we duplicated access control logic in the evaluation_detail view. This is suboptimal as it might get out of sync with the actual permissions.

It would be nice if we could refactor our framework to "think" in terms of those categories when answering the question "can user X see answer Y", so that we are then able to answer the "can user X see answers of category Y" as well.

@richardebeling richardebeling added [C] Backend Focuses on backend implementation [T] Refactoring Existing parts should become faster, more readable, or in any other way better. labels Jan 19, 2025
@janno42 janno42 added the [P] Medium Medium priority label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Backend Focuses on backend implementation [P] Medium Medium priority [T] Refactoring Existing parts should become faster, more readable, or in any other way better.
Development

No branches or pull requests

3 participants