Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request]: Replace outdated edit/delete/view button icons with FontAwesome equivalent. #5432

Open
CaMer0n opened this issue Feb 5, 2025 · 3 comments
Open

[Feature request]: Replace outdated edit/delete/view button icons with FontAwesome equivalent. #5432

CaMer0n opened this issue Feb 5, 2025 · 3 comments
Assignees
@CaMer0n
Labels
type: enhancement An improvement or new feature request
Milestone
e107 2.4.0

Comments

@CaMer0n
Copy link
Member

CaMer0n commented Feb 5, 2025

Motivation

Makes the admin feel dated.

Proposed Solution

FontAwesome icons instead.

Alternatives

Leave as is.

Additional Context

No response
@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Feb 5, 2025
@CaMer0n CaMer0n added this to the e107 2.4.0 milestone Feb 5, 2025
@CaMer0n CaMer0n self-assigned this Feb 5, 2025
CaMer0n added a commit that referenced this issue Feb 5, 2025
@CaMer0n
Issue #5432 - Replace admin-ui 'action' icons with FontAwesome.
e8dc885
CaMer0n added a commit that referenced this issue Feb 6, 2025
@CaMer0n
Issue #5382 #5432 Updated tests.
ab58afd
CaMer0n added a commit that referenced this issue Feb 7, 2025
@CaMer0n
Issue #5432 Styling
f772ab0
CaMer0n added a commit that referenced this issue Feb 7, 2025
@CaMer0n
Issue #5432
5b46d60
@Jimmi08
Copy link
Contributor

Jimmi08 commented Feb 9, 2025

Could you fix btn-danger class for delete and btn-success for edit buttons? It looks better that way. Thanks.

@rica-carv
Copy link
Contributor

Could you fix btn-danger class for delete and btn-success for edit buttons? It looks better that way. Thanks.

Or allow the btn class to be specified by the theme on the shortcode call?

@Jimmi08
Copy link
Contributor

Jimmi08 commented Feb 9, 2025

Could you fix btn-danger class for delete and btn-success for edit buttons? It looks better that way. Thanks.

Or allow the btn class to be specified by the theme on the shortcode call?

In admin area it is hardcoded only in cpage.php and form_handler. The front theme has nothing with this, there is already option class for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaMer0n CaMer0n

Labels
type: enhancement An improvement or new feature request
Projects
None yet
Milestone
e107 2.4.0
Development

No branches or pull requests
3 participants
@CaMer0n @Jimmi08 @rica-carv