Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: automate icon usage #2547

Open
ArtBlue opened this issue Jan 30, 2025 · 1 comment
Open

docs: automate icon usage #2547

ArtBlue opened this issue Jan 30, 2025 · 1 comment
Assignees
Milestone

Comments

@ArtBlue
Copy link
Contributor

ArtBlue commented Jan 30, 2025

As icons are renamed or removed by DS, the icons used throughout the docs can go missing. Without adequate manual checks after icons work, the docs can look broken.

Image

For this issue, create a docs component to use a random available icon to use in docs.

@ArtBlue ArtBlue self-assigned this Jan 30, 2025
@agliga agliga added this to eBayUI Jan 31, 2025
@agliga
Copy link
Contributor

agliga commented Jan 31, 2025

One thing we can do is to have tests to run our site and make sure there are no console.errors when we load the site. This is probably important even moreso now that we have separate pages and routes.
If an icon is missing, we can easily add a console.error so we can see if there are problems.

@agliga agliga added the size: 2 label Jan 31, 2025
@agliga agliga added this to the 19.1.0 milestone Jan 31, 2025
@agliga agliga moved this to Todo in eBayUI Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants