Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badge: update border #2549

Closed
1 of 3 tasks
cordeliadillon opened this issue Jan 31, 2025 · 0 comments
Closed
1 of 3 tasks

badge: update border #2549

cordeliadillon opened this issue Jan 31, 2025 · 0 comments
Assignees
@ArtBlue
Labels
design system Requested by the design system size: 1 type: enhancement
Milestone
19.1.0

Comments

@cordeliadillon
Copy link
Contributor

Description

Update border to use border.width.strong aligned outside of container (2px stroke on outside of container), using tokens

https://playbook.ebay.com/design-system/components/badge/

Screenshots

No response

Figma link

https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/?node-id=38612:44629

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@agliga agliga added this to eBayUI Jan 31, 2025
@agliga agliga added this to the 19.1.0 milestone Jan 31, 2025
@agliga agliga moved this to Todo in eBayUI Jan 31, 2025
@agliga agliga added design system Requested by the design system size: 1 and removed needs triage labels Jan 31, 2025
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Feb 3, 2025
@ArtBlue ArtBlue mentioned this issue Feb 4, 2025
Merged
9 tasks
@ArtBlue ArtBlue moved this from In Progress to Done in eBayUI Feb 4, 2025
@ArtBlue ArtBlue closed this as completed by moving to Done in eBayUI Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtBlue ArtBlue

Labels
design system Requested by the design system size: 1 type: enhancement
Projects
eBayUI
Status: Done
Milestone
19.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/2549-badge-update-border eBay/skin
3 participants
@ArtBlue @agliga @cordeliadillon